Return-Path: <issues-return-80310-archive-asf-public=cust-asf.ponee.io@flink.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id B9FC6200BC8
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Wed, 23 Nov 2016 11:12:04 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id B87D4160AFD; Wed, 23 Nov 2016 10:12:04 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 0E3EE160AFA
	for <archive-asf-public@cust-asf.ponee.io>; Wed, 23 Nov 2016 11:12:03 +0100 (CET)
Received: (qmail 38149 invoked by uid 500); 23 Nov 2016 10:12:03 -0000
Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@flink.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@flink.apache.org>
List-Post: <mailto:issues@flink.apache.org>
List-Id: <issues.flink.apache.org>
Reply-To: dev@flink.apache.org
Delivered-To: mailing list issues@flink.apache.org
Received: (qmail 38140 invoked by uid 99); 23 Nov 2016 10:12:03 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Nov 2016 10:12:03 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id A0181C1D50
	for <issues@flink.apache.org>; Wed, 23 Nov 2016 10:12:02 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: -7.018
X-Spam-Level: 
X-Spam-Status: No, score=-7.018 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5,
	RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
	RP_MATCHES_RCVD=-2.999, URIBL_BLOCKED=0.001] autolearn=disabled
Received: from mx1-lw-us.apache.org ([10.40.0.8])
	by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024)
	with ESMTP id 0soZO543bghP for <issues@flink.apache.org>;
	Wed, 23 Nov 2016 10:12:02 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 9BD975F1F0
	for <issues@flink.incubator.apache.org>; Wed, 23 Nov 2016 10:12:01 +0000 (UTC)
Received: (qmail 11401 invoked by uid 99); 23 Nov 2016 10:04:06 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Nov 2016 10:04:06 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id BF8ABE0AF6; Wed, 23 Nov 2016 10:04:06 +0000 (UTC)
From: mxm <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-2836-flink@git.apache.org>
In-Reply-To: <git-pr-2836-flink@git.apache.org>
Subject: [GitHub] flink pull request #2836: [FLINK-5092] Add maven profile with code coverage ...
Content-Type: text/plain
Message-Id: <20161123100406.BF8ABE0AF6@git1-us-west.apache.org>
Date: Wed, 23 Nov 2016 10:04:06 +0000 (UTC)
archived-at: Wed, 23 Nov 2016 10:12:04 -0000

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2836#discussion_r89284152
  
    --- Diff: flink-streaming-connectors/flink-connector-kafka-0.9/pom.xml ---
    @@ -193,9 +192,7 @@ under the License.
     				<configuration>
     					<!-- Enforce single fork execution due to heavy mini cluster use in the tests -->
     					<forkCount>1</forkCount>
    -					<systemPropertyVariables>
    -						<mvn.forkNumber>0${surefire.forkNumber}</mvn.forkNumber>
    -					</systemPropertyVariables>
    +					<argLine>-Xms256m -Xmx1000m -Dlog4j.configuration=${log4j.configuration} -XX:-UseGCOverheadLimit</argLine>
    --- End diff --
    
    I think this can be reduced to
    
    ```xml
    <argLine>@{argLine} -Xmx1000m</argLine>
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---