Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: fhueske <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-2653-flink@git.apache.org>
In-Reply-To: <git-pr-2653-flink@git.apache.org>
Subject: [GitHub] flink pull request #2653: [FLINK-4469] [table] Add support for user defined ...
Content-Type: text/plain
Message-Id: <20161116224930.35DD5F1789@git1-us-west.apache.org>
Date: Wed, 16 Nov 2016 22:49:30 +0000 (UTC)
archived-at: Wed, 16 Nov 2016 22:50:50 -0000

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2653#discussion_r88336518
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/functions/utils/UserDefinedFunctionUtils.scala ---
    @@ -135,6 +138,32 @@ object UserDefinedFunctionUtils {
       }
     
       /**
    +    * Returns eval method matching the given signature of [[TypeInformation]].
    +    */
    +  def getEvalMethod(
    +    function: EvaluableFunction,
    --- End diff --
    
    would't `Class[_]` be more generic than necessary. `UserDefinedFunction` would work as well, no?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---