Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: bjlovegithub <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-2629-flink@git.apache.org>
In-Reply-To: <git-pr-2629-flink@git.apache.org>
Subject: [GitHub] flink pull request #2629: [FLINK-4391] Provide support for asynchronous oper...
Content-Type: text/plain
Message-Id: <20161104095231.CBED4E09DE@git1-us-west.apache.org>
Date: Fri,  4 Nov 2016 09:52:31 +0000 (UTC)
archived-at: Fri, 04 Nov 2016 09:52:37 -0000

Github user bjlovegithub commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2629#discussion_r86514152
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/async/AsyncWaitOperator.java ---
    @@ -0,0 +1,256 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.streaming.api.operators.async;
    +
    +import org.apache.flink.annotation.Internal;
    +import org.apache.flink.api.common.typeutils.TypeSerializer;
    +import org.apache.flink.core.fs.FSDataInputStream;
    +import org.apache.flink.core.fs.FSDataOutputStream;
    +import org.apache.flink.core.memory.DataInputViewStreamWrapper;
    +import org.apache.flink.runtime.util.DataOutputSerializer;
    +import org.apache.flink.streaming.api.datastream.AsyncDataStream;
    +import org.apache.flink.streaming.api.functions.async.AsyncFunction;
    +import org.apache.flink.streaming.api.graph.StreamConfig;
    +import org.apache.flink.streaming.api.operators.AbstractUdfStreamOperator;
    +import org.apache.flink.streaming.api.operators.ChainingStrategy;
    +import org.apache.flink.streaming.api.operators.OneInputStreamOperator;
    +import org.apache.flink.streaming.api.operators.Output;
    +import org.apache.flink.streaming.api.operators.TimestampedCollector;
    +import org.apache.flink.streaming.api.watermark.Watermark;
    +import org.apache.flink.streaming.runtime.streamrecord.LatencyMarker;
    +import org.apache.flink.streaming.runtime.streamrecord.StreamElement;
    +import org.apache.flink.streaming.runtime.streamrecord.StreamRecord;
    +import org.apache.flink.streaming.runtime.tasks.StreamTask;
    +import org.apache.flink.util.Preconditions;
    +
    +import java.io.IOException;
    +import java.util.ArrayList;
    +import java.util.List;
    +
    +@Internal
    +public class AsyncWaitOperator<IN, OUT>
    +	extends AbstractUdfStreamOperator<OUT, AsyncFunction<IN, OUT>>
    +	implements OneInputStreamOperator<IN, OUT>
    +{
    +	private final int DEFAULT_BUFFER_SIZE = 1000;
    +
    +	private static final long serialVersionUID = 1L;
    +
    +	/**
    +	 * {@link TypeSerializer} for inputs while making snapshots.
    +	 */
    +	private transient TypeSerializer<IN> inTypeSerializer;
    +	private transient DataOutputSerializer outputSerializer;
    +
    +	/**
    +	 * input stream elements from the state
    +	 */
    +	private transient List<StreamElement> inputsFromState;
    +
    +	private transient TimestampedCollector<OUT> collector;
    +
    +	private transient AsyncCollectorBuffer<IN, OUT> buffer;
    +
    +	private int bufferSize = DEFAULT_BUFFER_SIZE;
    +	private AsyncDataStream.OutputMode mode;
    +
    +	public AsyncWaitOperator(AsyncFunction<IN, OUT> asyncFunction) {
    +		super(asyncFunction);
    +		chainingStrategy = ChainingStrategy.ALWAYS;
    +	}
    +
    +	public void setBufferSize(int size) {
    +		Preconditions.checkArgument(size > 0, "The number of concurrent async operation should be greater than 0.");
    +		bufferSize = size;
    +	}
    +
    +	public void setMode(AsyncDataStream.OutputMode mode) {
    +		this.mode = mode;
    +	}
    +
    +	public void init() {
    +		this.buffer = new AsyncCollectorBuffer<>(bufferSize, mode, this);
    +		this.collector = new TimestampedCollector<>(output);
    +		this.buffer.setOutput(collector, output);
    +
    +		this.outputSerializer = new DataOutputSerializer(128);
    +	}
    +
    +	@Override
    +	public void setup(StreamTask<?, ?> containingTask, StreamConfig config, Output<StreamRecord<OUT>> output) {
    +		super.setup(containingTask, config, output);
    +
    +		this.inTypeSerializer = this.getOperatorConfig().getTypeSerializerIn1(getUserCodeClassloader());
    +
    +		init();
    +	}
    +
    +	@Override
    +	public void open() throws Exception {
    +		super.open();
    +
    +		// process stream elements from state
    +		if (this.inputsFromState != null) {
    +			for (StreamElement element : this.inputsFromState) {
    +				if (element.isRecord()) {
    +					processElement(element.<IN>asRecord());
    +				} else {
    +					processWatermark(element.asWatermark());
    +				}
    --- End diff --
    
    This is a bug. Fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---