flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From 397090770 <...@git.apache.org>
Subject [GitHub] flink pull request #2799: [FLINK-5058]taskManagerMemory attribute set wrong ...
Date Mon, 14 Nov 2016 11:12:48 GMT
GitHub user 397090770 opened a pull request:

    https://github.com/apache/flink/pull/2799

    [FLINK-5058]taskManagerMemory attribute set wrong value

    In FlinkShell.scala, someone mistakenly set `slots` value to `taskManagerMemory` attribute
as follow:
    ```
    // set configuration from user input
    yarnConfig.jobManagerMemory.foreach((jmMem) => args ++= Seq("-yjm", jmMem.toString))
    yarnConfig.slots.foreach((tmMem) => args ++= Seq("-ytm", tmMem.toString))
    yarnConfig.name.foreach((name) => args ++= Seq("-ynm", name.toString))
    yarnConfig.queue.foreach((queue) => args ++= Seq("-yqu", queue.toString))
    yarnConfig.slots.foreach((slots) => args ++= Seq("-ys", slots.toString))
    ```
    Note on the third line: `yarnConfig.slots.foreach((tmMem) => args ++= Seq("-ytm", tmMem.toString))`
, we set `slots` value to `taskManagerMemory` attribute, But in fact, we want to set `taskManagerMemory`
attribute, the right code is as follow:
    ```
    // set configuration from user input
    yarnConfig.jobManagerMemory.foreach((jmMem) => args ++= Seq("-yjm", jmMem.toString))
    yarnConfig.taskManagerMemory.foreach((tmMem) => args ++= Seq("-ytm", tmMem.toString))
    yarnConfig.name.foreach((name) => args ++= Seq("-ynm", name.toString))
    yarnConfig.queue.foreach((queue) => args ++= Seq("-yqu", queue.toString))
    yarnConfig.slots.foreach((slots) => args ++= Seq("-ys", slots.toString))
    ```
    please review tihs pull, thanks.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/397090770/flink master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2799.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2799
    
----
commit f71f1d3f04f61500834c4d0d99d9b09df812781b
Author: iteblog <wyphao.2007@163.com>
Date:   2016-11-14T11:04:28Z

    taskManagerMemory attribute set wrong value
    
    taskManagerMemory attribute set wrong value

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message