flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From uce <...@git.apache.org>
Subject [GitHub] flink pull request #2795: Revert "[FLINK-4913][yarn] include user jars in sy...
Date Sat, 12 Nov 2016 19:55:23 GMT
GitHub user uce opened a pull request:

    https://github.com/apache/flink/pull/2795

    Revert "[FLINK-4913][yarn] include user jars in system class loader"

    In general, a very good fix imo, but it is part of RC1 for 1.1.4. It might be better to
exclude it for the bug fix release since it changes class loading behaviour between minor
version. This could possibly lead to hard to debug `Cannot cast class A to A exceptions` if
a user relies on loading classes via the user code loader which are available via the system
class loader with this commit.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/uce/flink 4913-revert_yarn_sysclassloader

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2795.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2795
    
----
commit 324ddaed54b138e11fac98b906b78a016f83a24b
Author: Ufuk Celebi <uce@apache.org>
Date:   2016-11-12T19:49:17Z

    Revert "[FLINK-4913][yarn] include user jars in system class loader"
    
    This reverts commit ea41b9c56fdc0af3c97d6dd48d04218db6176ec8.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message