flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5170) getAkkaConfig will use localhost if hostname is specified
Date Mon, 28 Nov 2016 09:17:59 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15701410#comment-15701410
] 

ASF GitHub Bot commented on FLINK-5170:
---------------------------------------

GitHub user shuai-xu opened a pull request:

    https://github.com/apache/flink/pull/2879

    [FLINK-5170] [runtime] fix mis judge of hostname in AkkaUtils

    This pr is for jira #[5170](https://issues.apache.org/jira/browse/FLINK-5170).
    
    in AkkaUtil.scala, 
    def getAkkaConfig(configuration: Configuration, hostname: String, port: Int): Config =
    { getAkkaConfig(configuration, if (hostname == null) Some((hostname, port)) else None)
}
    
    when hostname is specified, it use None.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shuai-xu/flink jira-5170

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2879.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2879
    
----
commit 48b3f1f5f3ad7bb4b1a1679c8a40eaa0124adb2b
Author: shuai.xus <shuai.xus@alibaba-inc.com>
Date:   2016-11-28T09:14:35Z

    [FLINK-5170] [runtime] fix mis judge of hostname in AkkaUtils

----


> getAkkaConfig will use localhost if hostname is specified 
> ----------------------------------------------------------
>
>                 Key: FLINK-5170
>                 URL: https://issues.apache.org/jira/browse/FLINK-5170
>             Project: Flink
>          Issue Type: Bug
>          Components: Core
>            Reporter: shuai.xu
>            Assignee: shuai.xu
>
> in AkkaUtil.scala, 
> def getAkkaConfig(configuration: Configuration, hostname: String, port: Int): Config
= {
>     getAkkaConfig(configuration, if (hostname == null) Some((hostname, port)) else None)
>   }
> when hostname is specified, it use None.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message