flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5169) Make consumption of input channels fair
Date Mon, 28 Nov 2016 10:51:59 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15701616#comment-15701616
] 

ASF GitHub Bot commented on FLINK-5169:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2882#discussion_r89757176
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java
---
    @@ -495,6 +518,27 @@ void triggerPartitionStateCheck(ResultPartitionID partitionId) {
     				partitionId);
     	}
     
    +	private void queueChannel(InputChannel channel) {
    +		int availableChannels;
    +
    +		synchronized (inputChannelsWithData) {
    +			availableChannels = inputChannelsWithData.size();
    +
    +			inputChannelsWithData.add(channel);
    +
    +			if (availableChannels == 0) {
    +				inputChannelsWithData.notify();
    --- End diff --
    
    This should be a `notifyAll()`.


> Make consumption of input channels fair
> ---------------------------------------
>
>                 Key: FLINK-5169
>                 URL: https://issues.apache.org/jira/browse/FLINK-5169
>             Project: Flink
>          Issue Type: Improvement
>          Components: Network
>            Reporter: Ufuk Celebi
>            Assignee: Ufuk Celebi
>            Priority: Critical
>             Fix For: 1.2.0, 1.1.4
>
>
> The input channels on the receiver side of the network stack queue incoming data and
notify the input gate about available data. These notifications currently determine the order
in which input channels are consumed, which can lead to unfair consumption patterns where
faster channels are favored over slower ones.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message