flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5167) StreamExecutionEnvironment's set function return `this` instead of void
Date Sat, 26 Nov 2016 08:50:58 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15697575#comment-15697575

ASF GitHub Bot commented on FLINK-5167:

Github user fhueske commented on the issue:

    The PR changes several `@Public` and `@PublicEvolving` methods. 
    We do not touch @Public interfaces for 1.x releases and also try to avoid to modify `@PublicEvolving`
interface except for very good reasons. We have a Maven plugin that prevents changes that
break the binary compatibility of methods and classes annotated with `@Public`. 
    By building the code before opening a pull request, you can early detect such issues.
    I don't think that we can and should merge this PR.

> StreamExecutionEnvironment's set function return `this` instead of void
> -----------------------------------------------------------------------
>                 Key: FLINK-5167
>                 URL: https://issues.apache.org/jira/browse/FLINK-5167
>             Project: Flink
>          Issue Type: Bug
>          Components: DataStream API
>            Reporter: shijinkui
> for example :
> public void setNumberOfExecutionRetries(int numberOfExecutionRetries) {
> 	config.setNumberOfExecutionRetries(numberOfExecutionRetries);
> }
> change to:
> public StreamExecutionEnvironment setNumberOfExecutionRetries(int numberOfExecutionRetries)
> 	config.setNumberOfExecutionRetries(numberOfExecutionRetries);
> 	return this;
> }

This message was sent by Atlassian JIRA

View raw message