flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5149) ContinuousEventTimeTrigger doesn't fire at the end of the window
Date Wed, 23 Nov 2016 15:03:58 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15690335#comment-15690335
] 

ASF GitHub Bot commented on FLINK-5149:
---------------------------------------

GitHub user mxm opened a pull request:

    https://github.com/apache/flink/pull/2860

    [FLINK-5149] let ContinuousEventTimeTrigger fire at the end of the window

    This changes the ContinuousEventTimeTrigger to behave like the
    EventTimeTrigger in the sense that it also triggers at the end of the
    window.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mxm/flink FLINK-5149

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2860.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2860
    
----
commit 18d3c2bd2dee225e274d0eda3bc7e5ccbe1ba3df
Author: Maximilian Michels <mxm@apache.org>
Date:   2016-11-23T15:01:35Z

    [FLINK-5149] let ContinuousEventTimeTrigger fire at the end of the window
    
    This changes the ContinuousEventTimeTrigger to behave like the
    EventTimeTrigger in the sense that it also triggers at the end of the
    window.

----


> ContinuousEventTimeTrigger doesn't fire at the end of the window
> ----------------------------------------------------------------
>
>                 Key: FLINK-5149
>                 URL: https://issues.apache.org/jira/browse/FLINK-5149
>             Project: Flink
>          Issue Type: Bug
>          Components: Streaming
>    Affects Versions: 1.1.3
>            Reporter: Maximilian Michels
>            Assignee: Maximilian Michels
>             Fix For: 1.2.0
>
>
> The ContinuousEventTimeTrigger registers a timer when elements arrive. The timers might
be registered past the end of the window. In this case, the window is cleaned up and doesn't
fire at all. That is certainly not what users have in mind when they use the custom trigger.
> I proposed to let it behave like a normal EventTimeTrigger in addition to its continuous
firing capabilities. So it should fire at the end of the window regardless of timers set.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message