flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5058) taskManagerMemory attribute set wrong value in FlinkShell
Date Thu, 17 Nov 2016 16:53:58 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15674195#comment-15674195
] 

ASF GitHub Bot commented on FLINK-5058:
---------------------------------------

Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/2799
  
    Merging


> taskManagerMemory attribute set wrong value in FlinkShell
> ---------------------------------------------------------
>
>                 Key: FLINK-5058
>                 URL: https://issues.apache.org/jira/browse/FLINK-5058
>             Project: Flink
>          Issue Type: Bug
>          Components: Scala Shell
>    Affects Versions: 1.1.3
>            Reporter: yangping wu
>   Original Estimate: 8h
>  Remaining Estimate: 8h
>
> In FlinkShell.scala, someone mistakenly set  {{slots}} value to {{taskManagerMemory}}
attribute as follow:
> {code}
> // set configuration from user input
> yarnConfig.jobManagerMemory.foreach((jmMem) => args ++= Seq("-yjm", jmMem.toString))
> yarnConfig.slots.foreach((tmMem) => args ++= Seq("-ytm", tmMem.toString))
> yarnConfig.name.foreach((name) => args ++= Seq("-ynm", name.toString))
> yarnConfig.queue.foreach((queue) => args ++= Seq("-yqu", queue.toString))
> yarnConfig.slots.foreach((slots) => args ++= Seq("-ys", slots.toString))
> {code}
> Note on the third line: {{yarnConfig.slots.foreach((tmMem) => args ++= Seq("-ytm",
tmMem.toString))}} , we set {{slots}} value to {{-ytm}} attribute, the right code should be:
> {code}
> // set configuration from user input
> yarnConfig.jobManagerMemory.foreach((jmMem) => args ++= Seq("-yjm", jmMem.toString))
> yarnConfig.taskManagerMemory.foreach((tmMem) => args ++= Seq("-ytm", tmMem.toString))
> yarnConfig.name.foreach((name) => args ++= Seq("-ynm", name.toString))
> yarnConfig.queue.foreach((queue) => args ++= Seq("-yqu", queue.toString))
> yarnConfig.slots.foreach((slots) => args ++= Seq("-ys", slots.toString))
> {code}
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message