flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4997) Extending Window Function Metadata
Date Tue, 15 Nov 2016 09:23:59 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15666627#comment-15666627
] 

ASF GitHub Bot commented on FLINK-4997:
---------------------------------------

Github user VenturaDelMonte commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2756#discussion_r87975777
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/WindowedStream.java
---
    @@ -459,7 +545,28 @@ public WindowedStream(KeyedStream<T, K> input,
     	 * @param resultType Type information for the result type of the window function
     	 * @return The data stream that is the result of applying the window function to the
window.
     	 */
    -	public <R> SingleOutputStreamOperator<R> apply(R initialValue, FoldFunction<T,
R> foldFunction, WindowFunction<R, R, K, W> function, TypeInformation<R> resultType)
{
    +	public <R> SingleOutputStreamOperator<R> apply(R initialValue, FoldFunction<T,
R> foldFunction,
    --- End diff --
    
    Thx for the review, first of all. I see your point here. I will introduce these ProcessWindowFunction-specific
fold/reduce methods, w/o altering the old WindowFunction API of course.


> Extending Window Function Metadata
> ----------------------------------
>
>                 Key: FLINK-4997
>                 URL: https://issues.apache.org/jira/browse/FLINK-4997
>             Project: Flink
>          Issue Type: New Feature
>          Components: DataStream API, Streaming, Windowing Operators
>            Reporter: Ventura Del Monte
>            Assignee: Ventura Del Monte
>             Fix For: 1.2.0
>
>
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-2+Extending+Window+Function+Metadata



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message