flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4541) Support for SQL NOT IN operator
Date Thu, 17 Nov 2016 11:36:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15673477#comment-15673477
] 

ASF GitHub Bot commented on FLINK-4541:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2811#discussion_r88432940
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/dataSet/DataSetSingleRowCrossRule.scala
---
    @@ -0,0 +1,88 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.api.table.plan.rules.dataSet
    +
    +import org.apache.calcite.plan.volcano.RelSubset
    +import org.apache.calcite.plan.{Convention, RelOptRule, RelOptRuleCall, RelTraitSet}
    +import org.apache.calcite.rel.RelNode
    +import org.apache.calcite.rel.convert.ConverterRule
    +import org.apache.calcite.rel.logical.{LogicalAggregate, LogicalJoin}
    +import org.apache.flink.api.table.plan.nodes.dataset.{DataSetConvention, DataSetSingleRowCross}
    +
    +class DataSetSingleRowCrossRule
    +  extends ConverterRule(
    +      classOf[LogicalJoin],
    +      Convention.NONE,
    +      DataSetConvention.INSTANCE,
    +      "DataSetSingleRowCrossRule") {
    +
    +  override def matches(call: RelOptRuleCall): Boolean = {
    +    val join = call.rel(0).asInstanceOf[LogicalJoin]
    +
    +    if (isCrossJoin(join)) {
    +      isGlobalAggregation(join.getRight.asInstanceOf[RelSubset].getOriginal) ||
    +        isGlobalAggregation(join.getLeft.asInstanceOf[RelSubset].getOriginal)
    +    } else {
    +      false
    +    }
    +  }
    +
    +  private def isCrossJoin(join: LogicalJoin) = {
    +    val joinCondition = join.analyzeCondition.pairs()
    +    joinCondition.isEmpty
    --- End diff --
    
    If we have the condition above, the rule will only trigger if the join condition is `TRUE`.
We could also allow for the case of `!joinCondition.isEqui` and evaluate the non-equi-join
condition in the `DataSetSingleRowCross`.
    
    With the current implementation, Calcite would generate an additional `DataSetCalc` which
evaluates the non-equi-join predicate after the join.


> Support for SQL NOT IN operator
> -------------------------------
>
>                 Key: FLINK-4541
>                 URL: https://issues.apache.org/jira/browse/FLINK-4541
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Alexander Shoshin
>
> This should work:
> {code}
> def main(args: Array[String]): Unit = {
>     // set up execution environment
>     val env = ExecutionEnvironment.getExecutionEnvironment
>     val tEnv = TableEnvironment.getTableEnvironment(env)
>     val input = env.fromElements(WC("hello", 1), WC("hello", 1), WC("ciao", 1))
>     // register the DataSet as table "WordCount"
>     tEnv.registerDataSet("WordCount", input, 'word, 'frequency)
>     tEnv.registerTable("WordCount2", tEnv.fromDataSet(input, 'word, 'frequency).select('word).filter('word
!== "hello"))
>     // run a SQL query on the Table and retrieve the result as a new Table
>     val table = tEnv.sql("SELECT word, SUM(frequency) FROM WordCount WHERE word NOT IN
(SELECT word FROM WordCount2) GROUP BY word")
>     table.toDataSet[WC].print()
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message