flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4288) Make it possible to unregister tables
Date Fri, 18 Nov 2016 20:57:59 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15677735#comment-15677735
] 

ASF GitHub Bot commented on FLINK-4288:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2511#discussion_r88737982
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/TableEnvironment.scala
---
    @@ -133,12 +134,24 @@ abstract class TableEnvironment(val config: TableConfig) {
             registerTableInternal(name, tableTable)
           case e: StreamTableEnvironment =>
             val sTableTable = new TransStreamTable(table.getRelNode, true)
    -        tables.add(name, sTableTable)
    +        schema.addTable(name, sTableTable)
         }
     
       }
     
       /**
    +    * Unregisters a [[Table]] in the TableEnvironment's catalog.
    +    * Unregistered tables cannot be referenced in SQL queries anymore.
    +    *
    +    * @param name The name under which the table is registered.
    +    */
    +  def unregisterTable(name: String): Unit = {
    --- End diff --
    
    Do we want to return a boolean success value or throw an exception if the table does not
exist?


> Make it possible to unregister tables
> -------------------------------------
>
>                 Key: FLINK-4288
>                 URL: https://issues.apache.org/jira/browse/FLINK-4288
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Timo Walther
>
> Table names can not be changed yet. After registration you can not modify the table behind
a table name. Maybe this behavior is too restrictive.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message