flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #2899: Various logging improvements
Date Wed, 30 Nov 2016 13:22:55 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2899#discussion_r90229315
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/TaskState.java
---
    @@ -168,4 +168,21 @@ public boolean equals(Object obj) {
     	public int hashCode() {
     		return parallelism + 31 * Objects.hash(jobVertexID, subtaskStates, kvStates);
     	}
    +
    +	@Override
    +	public String toString() {
    +		long stateSize = 0L;
    +		for (SubtaskState subtaskState : subtaskStates.values()) {
    +			stateSize += subtaskState.getStateSize();
    +		}
    --- End diff --
    
    can't we use the `getStateSize` method here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message