flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shijinkui <...@git.apache.org>
Subject [GitHub] flink issue #2541: [FLINK-4669] scala api createLocalEnvironment() function ...
Date Mon, 28 Nov 2016 15:00:23 GMT
Github user shijinkui commented on the issue:

    > In general, I think it is good to not have too many method options, but only those
that add significant functionality. For the method that starts the WebUI, that is the case,
for the method with the additional parallelism, probably not.
    Function having least parameters is the best style. If have no enough parameter for user,
the function's ability is limited. That's why I prefer Scala, as it has default parameter
value, keep the both.
    > The other Java code uses the primitive int everywhere, rather than the boxed integer.
Let's follow that style.
    Good idea. In the latest two years, I only wirte scala and give up Java entirely so that
not sensitive to Java. 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message