flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request #2732: [FLINK-4272] Create a JobClient for job control an...
Date Tue, 22 Nov 2016 15:30:23 GMT
Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2732#discussion_r89139969
  
    --- Diff: flink-clients/src/main/java/org/apache/flink/client/RemoteExecutor.java ---
    @@ -207,14 +207,23 @@ public JobExecutionResult executePlanWithJars(JobWithJars program)
throws Except
     				shutDownAtEnd = false;
     			}
     
    -			try {
    -				return client.run(program, defaultParallelism).getJobExecutionResult();
    -			}
    -			finally {
    -				if (shutDownAtEnd) {
    -					stop();
    -				}
    -			}
    +			final JobClient jobClient = client.run(program, defaultParallelism);
    +
    +			jobClient.addFinalizer(
    +				new Runnable() {
    +					@Override
    +					public void run() {
    +						if (shutDownAtEnd) {
    --- End diff --
    
    This closure should be fine since Java demands the variable to be final.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message