flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request #2836: [FLINK-5092] Add maven profile with code coverage ...
Date Tue, 22 Nov 2016 14:54:01 GMT
Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2836#discussion_r89130486
  
    --- Diff: flink-streaming-connectors/flink-connector-cassandra/pom.xml ---
    @@ -49,7 +50,9 @@ under the License.
     				<configuration>
     					<reuseForks>true</reuseForks>
     					<forkCount>1</forkCount>
    -					<argLine>-Xms256m -Xmx2800m -Dmvn.forkNumber=${surefire.forkNumber} -XX:-UseGCOverheadLimit</argLine>
    +					<systemPropertyVariables>
    +						<mvn.forkNumber>0${surefire.forkNumber}</mvn.forkNumber>
    +					</systemPropertyVariables>
    --- End diff --
    
    We can just remove all argLine definition here along with the forkNumber definition. They
are already defined in the parent pom.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message