flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sunjincheng121 <...@git.apache.org>
Subject [GitHub] flink issue #2792: [FLINK-4937] [Table] Add incremental group window aggrega...
Date Tue, 22 Nov 2016 06:39:20 GMT
Github user sunjincheng121 commented on the issue:

    https://github.com/apache/flink/pull/2792
  
    Hi,@fhueske  thanks a lot for the review. I have updated the PR according to your comments.
The change list:
     1. Amend code style(Including Class / Object / Trait / Method)
     2. Refactoring "createOperatorFunctionsForIncrementalAggregates" and "createOperatorFunctionsForAggregates"
     3. Move all "create*Window*Function" “isTimeWindow” and "computeWindowStartEndPropertyPos"
methods from DataStreamAggregate and DataSetAggregate to AggregateUtil
     4. Make “IncrementalAggregateReduceFunction”  a bit more lightweight.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message