flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #2837: [FLINK-5107] Introduced limit for prior execution ...
Date Mon, 21 Nov 2016 11:53:51 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2837#discussion_r88879433
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionVertex.java
---
    @@ -125,7 +142,7 @@ public ExecutionVertex(
     
     		this.inputEdges = new ExecutionEdge[jobVertex.getJobVertex().getInputs().size()][];
     
    -		this.priorExecutions = new CopyOnWriteArrayList<Execution>();
    +		this.priorExecutions = new EvictingBoundedList<>(maxPriorExecutionHistoryLength);
    --- End diff --
    
    Similarly, the ArchivedExecutionVertex is now probably broken if an execution was discarded
since the size checks in `getPriorExecutionAttempt` are not adjusted.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message