flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #2811: [FLINK-4541] Support for SQL NOT IN operator
Date Thu, 17 Nov 2016 11:35:35 GMT
Github user fhueske commented on a diff in the pull request:

    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/sql/JoinITCase.scala
    @@ -314,4 +315,18 @@ class JoinITCase(
         val results = tEnv.sql(sqlQuery).toDataSet[Row].collect()
         TestBaseUtils.compareResultAsText(results.asJava, expected)
    +  @Test(expected = classOf[TableException])
    +  def testCrossJoin(): Unit = {
    --- End diff --
    Good test to verify that we do not allow arbitrary cross joins!

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message