flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request #2804: [FLINK-5067] Make Flink compile with 1.8 Java comp...
Date Wed, 16 Nov 2016 14:10:19 GMT
Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2804#discussion_r88242077
  
    --- Diff: flink-java/src/test/java/org/apache/flink/api/common/operators/CollectionExecutionAccumulatorsTest.java
---
    @@ -35,7 +35,7 @@
     	@Test
     	public void testAccumulator() {
     		try {
    -			final int NUM_ELEMENTS = 100;
    +			final Integer NUM_ELEMENTS = 100;
    --- End diff --
    
    Can we stay, whereever possible, with primitive types? Rather unbox the type at a different
place?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message