flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wuchong <...@git.apache.org>
Subject [GitHub] flink pull request #2792: [FLINK-4937] [Table] Add incremental group window ...
Date Sun, 13 Nov 2016 09:14:52 GMT
Github user wuchong commented on a diff in the pull request:

    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/AggregateUtil.scala
    @@ -61,25 +61,108 @@ object AggregateUtil {
        * }}}
    -  def createOperatorFunctionsForAggregates(
    +    def createOperatorFunctionsForAggregates(
    --- End diff --
    It is a little confused that what's the difference between these two `createOperatorFunctionsForAggregates`
    Could we remove the first one, and call `transformToAggregateFunctions` explicitly before
`createOperatorFunctionsForAggregates` in DataSetAggregate ? 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message