flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tzulitai <...@git.apache.org>
Subject [GitHub] flink pull request #2789: [FLINK-5048] [Kafka Consumer] Change thread model ...
Date Fri, 11 Nov 2016 17:57:11 GMT
Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2789#discussion_r87621040
  
    --- Diff: flink-streaming-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThread.java
---
    @@ -0,0 +1,325 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.streaming.connectors.kafka.internal;
    +
    +import org.apache.flink.metrics.MetricGroup;
    +import org.apache.flink.streaming.connectors.kafka.internals.KafkaTopicPartitionState;
    +import org.apache.flink.streaming.connectors.kafka.internals.metrics.KafkaMetricWrapper;
    +import org.apache.kafka.clients.consumer.ConsumerRecords;
    +import org.apache.kafka.clients.consumer.KafkaConsumer;
    +import org.apache.kafka.clients.consumer.OffsetAndMetadata;
    +import org.apache.kafka.clients.consumer.OffsetCommitCallback;
    +import org.apache.kafka.common.Metric;
    +import org.apache.kafka.common.MetricName;
    +import org.apache.kafka.common.TopicPartition;
    +import org.apache.kafka.common.errors.WakeupException;
    +
    +import org.slf4j.Logger;
    +
    +import java.util.ArrayList;
    +import java.util.List;
    +import java.util.Map;
    +import java.util.Properties;
    +import java.util.concurrent.atomic.AtomicReference;
    +
    +import static org.apache.flink.util.Preconditions.checkNotNull;
    +
    +/**
    + * The thread the runs the {@link KafkaConsumer}, connecting to the brokers and polling
records.
    + * The thread pushes the data into a {@link Handover} to be picked up by the fetcher
that will
    + * deserialize and emit the records.
    + * 
    + * <p><b>IMPORTANT:</b> This thread must not be interrupted when attempting
to shut it down.
    + * The Kafka consumer code was found to not always handle interrupts well, and to even
    + * deadlock in certain situations.
    + * 
    + * <p>Implementation Note: This code is written to be reusable in later versions
of the KafkaConsumer.
    + * Because Kafka is not maintaining binary compatibility, we use a "call bridge" as an
indirection
    + * to the KafkaConsumer calls that change signature.
    + */
    +public class KafkaConsumerThread extends Thread {
    +
    +	/** Logger for this consumer */
    +	final Logger log;
    --- End diff --
    
    Private?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message