flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From thvasilo <...@git.apache.org>
Subject [GitHub] flink pull request #2542: [FLINK-4613] [ml] Extend ALS to handle implicit fe...
Date Thu, 10 Nov 2016 15:50:43 GMT
Github user thvasilo commented on a diff in the pull request:

    --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/recommendation/ALS.scala
    @@ -273,6 +308,14 @@ object ALS {
         val defaultValue: Option[Int] = Some(10)
    +  case object ImplicitPrefs extends Parameter[Boolean] {
    --- End diff --
    You are correct the recommendation is from the iALS paper, but I'm not sure if the same
holds for ALS. I trust your judgment here, since I'm not as familiar with xALS as I should
be to have a good intuition about this.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message