flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From thvasilo <...@git.apache.org>
Subject [GitHub] flink pull request #2542: [FLINK-4613] [ml] Extend ALS to handle implicit fe...
Date Wed, 09 Nov 2016 14:58:05 GMT
Github user thvasilo commented on a diff in the pull request:

    --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/recommendation/ALS.scala
    @@ -156,6 +171,26 @@ class ALS extends Predictor[ALS] {
    +  /** Sets the input observations to be implicit, thus using the iALS algorithm for learning.
    --- End diff --
    The docstring is not worded correctly, as the passed argument could be true or false.
    Should be prefixed with something like "When set to true, we assume implicit observations..."

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message