flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #2732: [FLINK-4272] Create a JobClient for job control an...
Date Wed, 09 Nov 2016 13:49:36 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2732#discussion_r87053103
  
    --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/JobClientEager.java
---
    @@ -0,0 +1,218 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.client.program;
    +
    +import org.apache.flink.api.common.JobClient;
    +import org.apache.flink.api.common.JobExecutionResult;
    +import org.apache.flink.api.common.JobID;
    +import org.apache.flink.api.common.accumulators.AccumulatorHelper;
    +import org.apache.flink.runtime.akka.AkkaUtils;
    +import org.apache.flink.runtime.client.JobClientActorUtils;
    +import org.apache.flink.runtime.client.JobClientActor;
    +import org.apache.flink.runtime.client.JobExecutionException;
    +import org.apache.flink.runtime.client.JobListeningContext;
    +import org.apache.flink.runtime.instance.ActorGateway;
    +import org.apache.flink.runtime.messages.JobManagerMessages;
    +import org.apache.flink.runtime.messages.accumulators.AccumulatorResultsErroneous;
    +import org.apache.flink.runtime.messages.accumulators.AccumulatorResultsFound;
    +import org.apache.flink.runtime.messages.accumulators.RequestAccumulatorResults;
    +import org.apache.flink.util.SerializedValue;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +import scala.concurrent.Await;
    +import scala.concurrent.Future;
    +
    +import java.util.LinkedList;
    +import java.util.List;
    +import java.util.Map;
    +
    +/**
    + * A client to interact with a running Flink job.
    + */
    +public class JobClientEager implements JobClient {
    +
    +	private final Logger LOG = LoggerFactory.getLogger(getClass());
    +
    +	/** The Job's listening context for monitoring and job interaction */
    +	private final JobListeningContext jobListeningContext;
    +
    +	/** Finalization code to run upon shutting down the JobClient */
    +	private final List<Runnable> finalizers;
    +
    +	public JobClientEager(JobListeningContext jobListeningContext) {
    +		this.jobListeningContext = jobListeningContext;
    +		this.finalizers = new LinkedList<>();
    +	}
    +
    +	/**
    +	 * Blocks until the job finishes and returns the {@link JobExecutionResult}
    +	 * @return the result of the job execution
    +	 */
    +	@Override
    +	public JobExecutionResult waitForResult() throws JobExecutionException {
    +		LOG.info("Waiting for results of Job {}", jobListeningContext.getJobID());
    +		JobExecutionResult result = JobClientActorUtils.awaitJobResult(jobListeningContext);
    +		shutdown();
    +		return result;
    +	}
    +
    +	/**
    +	 * Gets the job id that this client is bound to
    +	 * @return The JobID of this JobClient
    +	 */
    +	public JobID getJobID() {
    +		return jobListeningContext.getJobID();
    +	}
    +
    +	@Override
    +	public boolean hasFinished() {
    +		return jobListeningContext.getJobResultFuture().isCompleted();
    +	}
    +
    +	/**
    +	 * Cancels a job identified by the job id.
    +	 * @throws Exception In case an error occurred.
    +	 */
    +	@Override
    +	public void cancel() throws Exception {
    +		final ActorGateway jobClient = jobListeningContext.getJobClientGateway();
    +
    +		final Future<Object> response;
    +		try {
    +			response = jobClient.ask(
    +				new JobClientActor.ClientMessage(
    +					new JobManagerMessages.CancelJob(getJobID())),
    +				AkkaUtils.getDefaultTimeoutAsFiniteDuration());
    +		} catch (final Exception e) {
    +			throw new ProgramInvocationException("Failed to query the job manager gateway.", e);
    +		}
    +
    +		final Object result = Await.result(response, AkkaUtils.getDefaultTimeoutAsFiniteDuration());
    +
    +		if (result instanceof JobManagerMessages.CancellationSuccess) {
    +			LOG.info("Job cancellation with ID " + getJobID() + " succeeded.");
    --- End diff --
    
    Parameterized logging statement using `{}` is better.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message