flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aljoscha <...@git.apache.org>
Subject [GitHub] flink pull request #2736: [FLINK-4174] Enhance evictor functionality
Date Thu, 03 Nov 2016 16:46:36 GMT
Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2736#discussion_r86379042
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperator.java
---
    @@ -273,32 +284,93 @@ public void onProcessingTime(InternalTimer<K, W> timer) throws
Exception {
     			return;
     		}
     
    -		TriggerResult triggerResult = context.onProcessingTime(timer.getTimestamp());
    -		if (triggerResult.isFire()) {
    -			fire(context.window, contents);
    -		}
    +				TriggerResult triggerResult = context.onProcessingTime(timer.getTimestamp());
    --- End diff --
    
    Indentation seems off here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message