flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aljoscha <...@git.apache.org>
Subject [GitHub] flink pull request #2736: [FLINK-4174] Enhance evictor functionality
Date Thu, 03 Nov 2016 16:46:36 GMT
Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2736#discussion_r86377130
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/evictors/TimeEvictor.java
---
    @@ -65,11 +107,23 @@ public long getWindowSize() {
     	}
     
     	/**
    -	 * Creates a {@code TimeEvictor} that keeps the given number of elements.
    -	 *
    +	 * Creates an {@code TimeEvictor} that keeps the given number of elements.
    +	 * Eviction is done before the window function
     	 * @param windowSize The amount of time for which to keep elements.
     	 */
     	public static <W extends Window> TimeEvictor<W> of(Time windowSize) {
     		return new TimeEvictor<>(windowSize.toMilliseconds());
     	}
    +
    +	/**
    +	 * Creates an {@code TimeEvictor} that keeps the given number of elements.
    +	 * Eviction is done before/after the window function
    --- End diff --
    
    Missing full stop at the end of the sentence.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message