flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #2686: [FLINK-4743] The sqrt/power function not accept th...
Date Wed, 02 Nov 2016 13:22:34 GMT
Github user fhueske commented on a diff in the pull request:

    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/table/expressions/ScalarFunctionsTest.scala
    @@ -377,11 +378,79 @@ class ScalarFunctionsTest extends ExpressionTestBase {
           "POWER(f4, f5)",
           math.pow(44.toLong, 4.5.toFloat).toString)
    +    // f5: float
    +    testAllApis('f5.power('f5), "f5.power(f5)", "power(f5, f5)", math.pow(4.5F, 4.5F).toString)
    +    testAllApis('f5.power('f6), "f5.power(f6)", "power(f5, f6)", math.pow(4.5F, 4.6D).toString)
    +    testAllApis('f5.power('f7), "f5.power(f7)", "power(f5, f7)", math.pow(4.5F, 3).toString)
    +    testAllApis('f5.power('f4), "f5.power(f4)", "power(f5, f4)", math.pow(4.5F, 44L).toString)
    +    // f22: bigDecimal
    +    // TODO delete casting in SQL when CALCITE-1467 is fixed
    +    testAllApis(
    +      'f22.cast(Types.DOUBLE).power('f4),
    +      "f22.cast(DOUBLE).power(f5)",
    --- End diff --
    Shouldn't this be `"f22.cast(DOUBLE).power(f4)"`?
    Same for SQL expression.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message