Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 66E68200B98 for ; Mon, 3 Oct 2016 22:41:37 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 65686160ADC; Mon, 3 Oct 2016 20:41:37 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A1AD9160ACD for ; Mon, 3 Oct 2016 22:41:36 +0200 (CEST) Received: (qmail 53340 invoked by uid 500); 3 Oct 2016 20:41:35 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 53328 invoked by uid 99); 3 Oct 2016 20:41:35 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Oct 2016 20:41:35 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 6B5FF180516 for ; Mon, 3 Oct 2016 20:41:35 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -7.019 X-Spam-Level: X-Spam-Status: No, score=-7.019 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id XSnzfXPoxrTm for ; Mon, 3 Oct 2016 20:41:33 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 88DB15FB75 for ; Mon, 3 Oct 2016 20:41:32 +0000 (UTC) Received: (qmail 53030 invoked by uid 99); 3 Oct 2016 20:41:31 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Oct 2016 20:41:31 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 9717AE009E; Mon, 3 Oct 2016 20:41:31 +0000 (UTC) From: greghogan To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org Message-ID: Subject: [GitHub] flink pull request #2582: [FLINK-4728] [core,optimizer] Replace reference eq... Content-Type: text/plain Date: Mon, 3 Oct 2016 20:41:31 +0000 (UTC) archived-at: Mon, 03 Oct 2016 20:41:37 -0000 GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/2582 [FLINK-4728] [core,optimizer] Replace reference equality with object equality Some cases of testing Integer equality using == rather than Integer.equals(Integer), and some additional cleanup. You can merge this pull request into a Git repository by running: $ git pull https://github.com/greghogan/flink 4728_replace_reference_equality_with_object_equality Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2582.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2582 ---- commit 409883eb3c3ffa7a94ad25e67cfd6dfdc25010ba Author: Greg Hogan Date: 2016-10-03T17:59:57Z [FLINK-4728] [core,optimizer] Replace reference equality with object equality Some cases of testing Integer equality using == rather than Integer.equals(Integer), and some additional cleanup. ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---