Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1178C200BBB for ; Wed, 26 Oct 2016 12:26:00 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 10441160AEE; Wed, 26 Oct 2016 10:26:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 600BC160ACA for ; Wed, 26 Oct 2016 12:25:59 +0200 (CEST) Received: (qmail 24299 invoked by uid 500); 26 Oct 2016 10:25:58 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 24216 invoked by uid 99); 26 Oct 2016 10:25:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Oct 2016 10:25:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 6CF982C14F9 for ; Wed, 26 Oct 2016 10:25:58 +0000 (UTC) Date: Wed, 26 Oct 2016 10:25:58 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-4155) Get Kafka producer partition info in open method instead of constructor MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 26 Oct 2016 10:26:00 -0000 [ https://issues.apache.org/jira/browse/FLINK-4155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15608079#comment-15608079 ] ASF GitHub Bot commented on FLINK-4155: --------------------------------------- Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2681 Looks good to me. I think it would be good if @rmetzger also had a look. Concerning the Table sink tests and the mocking of the producer: Do these tests need a Kafka cluster running at all? They are just a think layer on top of the producer, which should be covered with Unit tests and not need a Kafka cluster. > Get Kafka producer partition info in open method instead of constructor > ----------------------------------------------------------------------- > > Key: FLINK-4155 > URL: https://issues.apache.org/jira/browse/FLINK-4155 > Project: Flink > Issue Type: Bug > Components: Kafka Connector > Affects Versions: 1.1.0, 1.0.3 > Reporter: Gyula Fora > Assignee: Tzu-Li (Gordon) Tai > Fix For: 1.2.0 > > > Currently the Flink Kafka producer does not really do any error handling if something is wrong with the partition metadata as it is serialized with the user function. > This means that in some cases the job can go into an error loop when using the checkpoints. Getting the partition info in the open method would solve this problem (like restarting from a savepoint which re-runs the constructor). -- This message was sent by Atlassian JIRA (v6.3.4#6332)