Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: zentol <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-2616-flink@git.apache.org>
In-Reply-To: <git-pr-2616-flink@git.apache.org>
Subject: [GitHub] flink pull request #2616: [FLINK-4733] Port WebInterface to metric system
Content-Type: text/plain
Message-Id: <20161025095406.046D5DFB90@git1-us-west.apache.org>
Date: Tue, 25 Oct 2016 09:54:06 +0000 (UTC)
archived-at: Tue, 25 Oct 2016 09:54:09 -0000

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2616#discussion_r84867488
  
    --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JobDetailsHandler.java ---
    @@ -147,11 +143,36 @@ public String handleRequest(ExecutionGraph graph, Map<String, String> params) th
     			}
     			gen.writeEndObject();
     			
    +			long numBytesIn = 0;
    +			long numBytesOut = 0;
    +			long numRecordsIn = 0;
    +			long numRecordsOut = 0;
    +
    +			for (ExecutionVertex vertex : ejv.getTaskVertices()) {
    +				IOMetrics ioMetrics = vertex.getCurrentExecutionAttempt().getIOMetrics();
    +
    +				if (ioMetrics != null) { // execAttempt is already finished, use final metrics stored in ExecutionGraph
    +					numBytesIn += ioMetrics.getNumBytesInLocal() + ioMetrics.getNumBytesInRemote();
    --- End diff --
    
    That's a relic from the previous iterations, `getNumBytesInTotal()` did not always exist :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---