Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: fhueske <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-1975-flink@git.apache.org>
In-Reply-To: <git-pr-1975-flink@git.apache.org>
Subject: [GitHub] flink pull request #1975: [FLINK-2184] Cannot get last element with maxBy/mi...
Content-Type: text/plain
Message-Id: <20161013214940.DD559E0ADC@git1-us-west.apache.org>
Date: Thu, 13 Oct 2016 21:49:40 +0000 (UTC)
archived-at: Thu, 13 Oct 2016 21:49:45 -0000

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1975#discussion_r83309671
  
    --- Diff: flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/AllWindowedStream.scala ---
    @@ -361,38 +361,84 @@ class AllWindowedStream[T, W <: Window](javaStream: JavaAllWStream[T, W]) {
     
       /**
        * Applies an aggregation that that gives the maximum element of the window by
    -   * the given position. When equality, returns the first.
    +   * the given position. When equality, returns the first by default.
        */
       def maxBy(position: Int): DataStream[T] = aggregate(AggregationType.MAXBY,
    -    position)
    +    position, true)
     
       /**
        * Applies an aggregation that that gives the maximum element of the window by
    -   * the given field. When equality, returns the first.
    +   * the given position. When equality, returns either the first or last one depending
    +   * on the parameter setting.
    +   */
    +  def maxBy(position: Int, first: Boolean): DataStream[T] = aggregate(AggregationType.MAXBY,
    --- End diff --
    
    Please annotate all new public methods with `@PublicEvolving`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---