Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8CFC4200B96 for ; Thu, 6 Oct 2016 16:59:58 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 8B813160AC6; Thu, 6 Oct 2016 14:59:58 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C817B160AAD for ; Thu, 6 Oct 2016 16:59:57 +0200 (CEST) Received: (qmail 41118 invoked by uid 500); 6 Oct 2016 14:59:56 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 41109 invoked by uid 99); 6 Oct 2016 14:59:56 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Oct 2016 14:59:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 8E22CC9AB4 for ; Thu, 6 Oct 2016 14:59:56 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -7.019 X-Spam-Level: X-Spam-Status: No, score=-7.019 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id YiQPuxWZZkrw for ; Thu, 6 Oct 2016 14:59:56 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 9E19B5F307 for ; Thu, 6 Oct 2016 14:59:55 +0000 (UTC) Received: (qmail 41096 invoked by uid 99); 6 Oct 2016 14:59:55 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Oct 2016 14:59:55 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 751EAE0061; Thu, 6 Oct 2016 14:59:54 +0000 (UTC) From: StephanEwen To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink issue #2588: [FLINK-4735] [cluster management] Migrate some job execut... Content-Type: text/plain Message-Id: <20161006145954.751EAE0061@git1-us-west.apache.org> Date: Thu, 6 Oct 2016 14:59:54 +0000 (UTC) archived-at: Thu, 06 Oct 2016 14:59:58 -0000 Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2588 Looks good, thanks, will merge this. I would suggest two followups: - We can remove the "dispose savepoint" method, because that is functionality disappearing right now. Savepoints need no special remove logic any more, they are just a directory in a filesystem. - We can reduce the number of message classes (like `TriggerSavepointResponse`) by using exceptions more prominently. The "triggerSavepoint()" method could simply return a String (success) or throw an exception (failure). Exceptions are propagated by the RPC, so the caller future will always get it as a response. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---