flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request #2621: [FLINK-4793] [types] Improve lambda constructor re...
Date Tue, 11 Oct 2016 13:43:47 GMT
GitHub user twalthr opened a pull request:

    https://github.com/apache/flink/pull/2621

    [FLINK-4793] [types] Improve lambda constructor reference handling

    Thanks for contributing to Apache Flink. Before you open your pull request, please take
the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request.
For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your
changes.
    
    - [x] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [x] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [x] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    
    This PR further improves the handling of Java 8 lambdas. It improves the handling of constructor
references. The following is now possible:
    
    `env.fromElements("xx", "xx").map(Trade::new).map(Trade::toString).print();`
    
    Unfortunately, I had to add the ASM dependency to `flink-core`. I hope this is not a problem.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/twalthr/flink FLINK-4793

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2621.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2621
    
----
commit 0e85f7273dab446f71d832bf453d3dcc96c41599
Author: twalthr <twalthr@apache.org>
Date:   2016-10-11T13:33:20Z

    [FLINK-4793] [types] Improve lambda constructor reference handling

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message