flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4933) ExecutionGraph.scheduleOrUpdateConsumers can fail the ExecutionGraph
Date Thu, 27 Oct 2016 11:14:59 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15611564#comment-15611564
] 

ASF GitHub Bot commented on FLINK-4933:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/2701

    [backport] [FLINK-4933] [exec graph] Don't let the EG fail in case of a failing scheduleOrUpdateConsumers
call

    This is a backport for the release-1.1 branch. The only thing adapted is the added test
case.
    
    Instead of failing the complete ExecutionGraph, a failing scheduleOrUpdateConsumers call
    will be reported back to the caller. The caller can then decide what to do. Per default,
    it will fail the calling task.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink backportFixScheduleOrUpdateConsumers

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2701.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2701
    
----
commit b17fada0e60ad9986680c89effa628944973d999
Author: Till Rohrmann <trohrmann@apache.org>
Date:   2016-10-27T09:41:29Z

    [FLINK-4933] [exec graph] Don't let the EG fail in case of a failing scheduleOrUpdateConsumers
call
    
    Instead of failing the complete ExecutionGraph, a failing scheduleOrUpdateConsumers call
    will be reported back to the caller. The caller can then decide what to do. Per default,
    it will fail the calling task.
    
    Adapt TaskManagerTest

----


> ExecutionGraph.scheduleOrUpdateConsumers can fail the ExecutionGraph
> --------------------------------------------------------------------
>
>                 Key: FLINK-4933
>                 URL: https://issues.apache.org/jira/browse/FLINK-4933
>             Project: Flink
>          Issue Type: Bug
>          Components: Distributed Coordination
>    Affects Versions: 1.2.0, 1.1.3
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>             Fix For: 1.2.0, 1.1.4
>
>
> Currently the {{ExecutionGraph.scheduleOrUpdateConsumers}} can fail the whole {{ExecutionGraph}}
if it cannot find the corresponding {{Execution}}. This situation can occur in the restarting
scenario where we have a late callback trying to update its consumers. In this case, the call
should forward the exception back to the caller and not fail the {{ExecutionGraph}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message