flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4887) Replace ActorGateway by TaskManagerGateway interface
Date Thu, 27 Oct 2016 18:14:59 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15612674#comment-15612674
] 

ASF GitHub Bot commented on FLINK-4887:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2699#discussion_r85390985
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/messages/StackTraceSampleResponse.java
---
    @@ -0,0 +1,57 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.messages;
    +
    +import org.apache.flink.runtime.executiongraph.ExecutionAttemptID;
    +import org.apache.flink.util.Preconditions;
    +
    +import java.util.List;
    +
    +/**
    + * Response to the TriggerStackTraceSample message.
    + */
    +public class StackTraceSampleResponse {
    --- End diff --
    
    This needs to be `java.io.Serializable`


> Replace ActorGateway by TaskManagerGateway interface
> ----------------------------------------------------
>
>                 Key: FLINK-4887
>                 URL: https://issues.apache.org/jira/browse/FLINK-4887
>             Project: Flink
>          Issue Type: Bug
>    Affects Versions: 1.2.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>             Fix For: 1.2.0
>
>
> Instead of accessing directly on the {{ActorGateway}} in the {{Execution}} and {{ExecutionVertex}}
it would be better to decouple the two components by introducing the {{TaskGateway}} interface
which provides access to task related rpc calls. The {{ActorGateway}} could be one implementation
of the interface.
> This change will prepare the further implementation of Flip-6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message