flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4863) states of merging window and trigger are set to different TimeWindows on merge
Date Thu, 20 Oct 2016 07:17:58 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15591051#comment-15591051

ASF GitHub Bot commented on FLINK-4863:

GitHub user manuzhang opened a pull request:


    [FLINK-4863] fix trigger context window on merge

    Thanks for contributing to Apache Flink. Before you open your pull request, please take
the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request.
For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your
    - [ ] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    - [ ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/manuzhang/flink fix_merge_window

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2666
commit ce1aaba4e0208505e88ce1507533eaeab1f62321
Author: manuzhang <owenzhang1990@gmail.com>
Date:   2016-10-20T07:06:01Z

    [FLINK-4863] fix trigger context window on merge


> states of merging window and trigger are set to different TimeWindows on merge
> ------------------------------------------------------------------------------
>                 Key: FLINK-4863
>                 URL: https://issues.apache.org/jira/browse/FLINK-4863
>             Project: Flink
>          Issue Type: Bug
>          Components: Streaming, Windowing Operators
>            Reporter: Manu Zhang
> While window state is set to the mergeResult's stateWindow (one of original windows),
trigger state is set to the mergeResult itself. This will fail {{Timer}} of  {{ContinuousEventTimeTrigger}}
since its window cannot be found in the window state.

This message was sent by Atlassian JIRA

View raw message