flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4851) Add FatalErrorHandler and MetricRegistry to ResourceManager
Date Fri, 21 Oct 2016 15:53:58 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15595486#comment-15595486
] 

ASF GitHub Bot commented on FLINK-4851:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2655#discussion_r84507291
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/util/TestingFatalErrorHandler.java
---
    @@ -0,0 +1,83 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.util;
    +
    +import org.apache.flink.runtime.rpc.FatalErrorHandler;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import java.util.concurrent.atomic.AtomicReference;
    +
    +/**
    + * Testing fatal error handler which records the occurred exceptions during the execution
of the
    + * tests. Captured exceptions are thrown as a {@link TestingException}.
    + */
    +public class TestingFatalErrorHandler implements FatalErrorHandler {
    +	private static final Logger LOG = LoggerFactory.getLogger(TestingFatalErrorHandler.class);
    +	private final AtomicReference<Throwable> atomicThrowable;
    +
    +	public TestingFatalErrorHandler() {
    +		atomicThrowable = new AtomicReference<>(null);
    +	}
    +
    +	public void rethrowError() throws TestingException {
    +		Throwable throwable = atomicThrowable.get();
    +
    +		if (throwable != null) {
    +			throw new TestingException(throwable);
    +		}
    +	}
    +
    +	public boolean hasExceptionOccurred() {
    +		return atomicThrowable.get() != null;
    +	}
    +
    +	public Throwable getException() {
    +		return atomicThrowable.get();
    +	}
    +
    +	@Override
    +	public void onFatalError(Throwable exception) {
    +		LOG.error("OnFatalError:", exception);
    +
    +		if (!atomicThrowable.compareAndSet(null, exception)) {
    +			atomicThrowable.get().addSuppressed(exception);
    +		}
    --- End diff --
    
    Oh, I didn't know you could do that. That's neat.


> Add FatalErrorHandler and MetricRegistry to ResourceManager
> -----------------------------------------------------------
>
>                 Key: FLINK-4851
>                 URL: https://issues.apache.org/jira/browse/FLINK-4851
>             Project: Flink
>          Issue Type: Sub-task
>          Components: ResourceManager
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>
> The {{ResourceManager}} currently does not contain a {{FatalErrorHandler}}. In order
to harmonize the fatal error handling across all components, we should introduce a {{FatalErrorHandler}},
which handles fatal errors. Additionally, we should also give a {{MetricRegistry}} to the
{{ResourceManager}} so that it can report metrics.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message