flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4847) Let RpcEndpoint.start/shutDown throw exceptions
Date Mon, 17 Oct 2016 14:24:58 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15582405#comment-15582405
] 

ASF GitHub Bot commented on FLINK-4847:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/2651

    [FLINK-4847] Let RpcEndpoint.start/shutDown throw exceptions

    Allowing the RpcEndpoint.start/shutDown to throw exceptions will help to let rpc endpoints
    to quickly fail without having to use a callback like the FatalErrorHandler.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink rpcExceptions

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2651.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2651
    
----
commit ddf35c4ddb04629cddebb2401488effe93416b70
Author: Till Rohrmann <trohrmann@apache.org>
Date:   2016-10-17T14:22:16Z

    [FLINK-4847] Let RpcEndpoint.start/shutDown throw exceptions
    
    Allowing the RpcEndpoint.start/shutDown to throw exceptions will help to let rpc endpoints
    to quickly fail without having to use a callback like the FatalErrorHandler.

----


> Let RpcEndpoint.start/shutDown throw exceptions
> -----------------------------------------------
>
>                 Key: FLINK-4847
>                 URL: https://issues.apache.org/jira/browse/FLINK-4847
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>
> The {{RpcEndpoint.start}} and {{RpcEndpoint.shutDown}} methods should be allowed to throw
exceptions if things go wrong. Otherwise, exceptions will be given to a callback which handles
them later, even though we know that we can fail the components right away (as it is the case
for the {{TaskExectuor}}, for example).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message