flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4731) HeapKeyedStateBackend restoring broken for scale-in
Date Thu, 06 Oct 2016 15:42:21 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15552272#comment-15552272
] 

ASF GitHub Bot commented on FLINK-4731:
---------------------------------------

Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2584#discussion_r82211497
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/savepoint/SavepointV1Serializer.java
---
    @@ -290,6 +290,7 @@ public static void serializeStreamStateHandle(StreamStateHandle stateHandle,
Dat
     		} else if (stateHandle instanceof ByteStreamStateHandle) {
     			dos.writeByte(BYTE_STREAM_STATE_HANDLE);
     			ByteStreamStateHandle byteStreamStateHandle = (ByteStreamStateHandle) stateHandle;
    +			dos.writeUTF(byteStreamStateHandle.getHandleName());
    --- End diff --
    
    I think it's OK that we don't change the format version (e.g. to v2) when we change the
serialization format in a snapshot version right? Since 1.1 the version was already updated,
which is fine.


> HeapKeyedStateBackend restoring broken for scale-in
> ---------------------------------------------------
>
>                 Key: FLINK-4731
>                 URL: https://issues.apache.org/jira/browse/FLINK-4731
>             Project: Flink
>          Issue Type: Bug
>          Components: State Backends, Checkpointing
>            Reporter: Stefan Richter
>            Assignee: Stefan Richter
>
> Restoring the HeapKeyedStateBackend is broken in case that parallelism is reduced. The
restore method is overwriting previously restored state.
> We should also add scale-in testing to the RescalingITCase.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message