flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4691) Add group-windows for streaming tables
Date Fri, 07 Oct 2016 10:08:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15554707#comment-15554707

ASF GitHub Bot commented on FLINK-4691:

Github user twalthr commented on the issue:

    Thanks for reviewing this PR @fhueske. I hope I could fix all the feedback you gave me.
I also added documentation for the website in my last commit.
    Regarding the two big changes you mentioned:
    1. IMHO window properties also summarize the data. So they can be considered as an aggregation
of the data in a window. I also chose this approach to keep the code clean and readable (window
properties and aggregations have more in common than window properties and grouping keys).
Otherwise we have to somehow hack the window property into the record after the aggregation
happened. I will try to improve this but I'm not sure if the outcome will be a nicer solution.
    2. Once #2595 is merged I will rebase this PR and convert ITCases to unit tests.

> Add group-windows for streaming tables	
> ---------------------------------------
>                 Key: FLINK-4691
>                 URL: https://issues.apache.org/jira/browse/FLINK-4691
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Timo Walther
> Add Tumble, Slide, Session group-windows for streaming tables as described in [FLIP-11|https://cwiki.apache.org/confluence/display/FLINK/FLIP-11%3A+Table+API+Stream+Aggregations].

> Implementation of group-windows on streaming tables. This includes implementing the API
of group-windows, the logical validation for group-windows, and the definition of the “rowtime”
and “systemtime” keywords. Group-windows on batch tables won’t be initially supported
and will throw an exception.

This message was sent by Atlassian JIRA

View raw message