flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4691) Add group-windows for streaming tables
Date Thu, 06 Oct 2016 08:42:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551341#comment-15551341
] 

ASF GitHub Bot commented on FLINK-4691:
---------------------------------------

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2562#discussion_r82141352
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala
---
    @@ -55,28 +56,27 @@ case class Project(projectList: Seq[NamedExpression], child: LogicalNode)
extend
     
       override def validate(tableEnv: TableEnvironment): LogicalNode = {
         val resolvedProject = super.validate(tableEnv).asInstanceOf[Project]
    +    val names: mutable.Set[String] = mutable.Set()
     
    -    def checkUniqueNames(exprs: Seq[Expression]): Unit = {
    -      val names: mutable.Set[String] = mutable.Set()
    -      exprs.foreach {
    -        case n: Alias =>
    -          // explicit name
    -          if (names.contains(n.name)) {
    -            throw ValidationException(s"Duplicate field name ${n.name}.")
    -          } else {
    -            names.add(n.name)
    -          }
    -        case r: ResolvedFieldReference =>
    -          // simple field forwarding
    -          if (names.contains(r.name)) {
    -            throw ValidationException(s"Duplicate field name ${r.name}.")
    -          } else {
    -            names.add(r.name)
    -          }
    -        case _ => // Do nothing
    +    def checkName(name: String): Unit = {
    +      if (names.contains(name)) {
    +        throw ValidationException(s"Duplicate field name $name.")
    --- End diff --
    
    Done.


> Add group-windows for streaming tables	
> ---------------------------------------
>
>                 Key: FLINK-4691
>                 URL: https://issues.apache.org/jira/browse/FLINK-4691
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Timo Walther
>
> Add Tumble, Slide, Session group-windows for streaming tables as described in [FLIP-11|https://cwiki.apache.org/confluence/display/FLINK/FLIP-11%3A+Table+API+Stream+Aggregations].

> Implementation of group-windows on streaming tables. This includes implementing the API
of group-windows, the logical validation for group-windows, and the definition of the “rowtime”
and “systemtime” keywords. Group-windows on batch tables won’t be initially supported
and will throw an exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message