flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Fabian Hueske (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (FLINK-4506) CsvOutputFormat defaults allowNullValues to false, even though doc and declaration says true
Date Sat, 15 Oct 2016 07:55:20 GMT

     [ https://issues.apache.org/jira/browse/FLINK-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Fabian Hueske resolved FLINK-4506.
----------------------------------
       Resolution: Fixed
    Fix Version/s: 1.1.4
                   1.2.0

Fixed for 1.1.4 with 9591d50fc6f3b2d7fab3af7aeee29e04d11b7811
Fixed for 1.2.0 with a85d8e57a3501e39284e24221b50c6222e85c06c

> CsvOutputFormat defaults allowNullValues to false, even though doc and declaration says
true
> --------------------------------------------------------------------------------------------
>
>                 Key: FLINK-4506
>                 URL: https://issues.apache.org/jira/browse/FLINK-4506
>             Project: Flink
>          Issue Type: Bug
>          Components: Batch Connectors and Input/Output Formats, Documentation
>            Reporter: Michael Wong
>            Assignee: Kirill Morozov
>            Priority: Minor
>             Fix For: 1.2.0, 1.1.4
>
>
> In the constructor, it has this
> {code}
> this.allowNullValues = false;
> {code}
> But in the setAllowNullValues() method, the doc says the allowNullValues is true by default.
Also, in the declaration of allowNullValues, the value is set to true. It probably makes the
most sense to change the constructor.
> {code}
> 	/**
> 	 * Configures the format to either allow null values (writing an empty field),
> 	 * or to throw an exception when encountering a null field.
> 	 * <p>
> 	 * by default, null values are allowed.
> 	 *
> 	 * @param allowNulls Flag to indicate whether the output format should accept null values.
> 	 */
> 	public void setAllowNullValues(boolean allowNulls) {
> 		this.allowNullValues = allowNulls;
> 	}
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message