flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chermenin <...@git.apache.org>
Subject [GitHub] flink pull request #2723: [FLINK-3617] Simple fix for OptionSerializer.
Date Mon, 31 Oct 2016 19:19:36 GMT
Github user chermenin commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2723#discussion_r85812829
  
    --- Diff: flink-scala/src/main/scala/org/apache/flink/api/scala/typeutils/OptionSerializer.scala
---
    @@ -65,7 +65,7 @@ class OptionSerializer[A](val elemSerializer: TypeSerializer[A])
         case Some(a) =>
           target.writeBoolean(true)
           elemSerializer.serialize(a, target)
    -    case None =>
    +    case _ =>
    --- End diff --
    
    I understand. Is there possible this case as serialization with new serializer and deserialization
with old one? Exception will be in this case, isn't it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message