flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #2699: [FLINK-4887] [execution graph] Introduce TaskManag...
Date Mon, 31 Oct 2016 15:36:10 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2699#discussion_r85764785
  
    --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/TaskManagerLogHandler.java
---
    @@ -243,22 +284,29 @@ public void onSuccess(Object filePathOption) throws Throwable {
     								@Override
     								public void operationComplete(
     									io.netty.util.concurrent.Future<? super Void> future) throws Exception
{
    -										lastRequestPending.remove(taskManagerID);
    -										fc.close();
    -										raf.close();
    +									lastRequestPending.remove(taskManagerID);
    --- End diff --
    
    Thanks for spotting this. Will fix it right away :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message