flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #2691: [FLINK-4910] Introduce safety net for closing file...
Date Fri, 28 Oct 2016 17:04:27 GMT
Github user tillrohrmann commented on a diff in the pull request:

    --- Diff: flink-core/src/main/java/org/apache/flink/core/fs/SafetyNetCloseableRegistry.java
    @@ -0,0 +1,181 @@
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.core.fs;
    +import org.apache.flink.util.AbstractCloseableRegistry;
    +import org.apache.flink.util.IOUtils;
    +import org.apache.flink.util.Preconditions;
    +import org.apache.flink.util.WrappingProxyUtil;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +import java.io.Closeable;
    +import java.io.IOException;
    +import java.lang.ref.PhantomReference;
    +import java.lang.ref.ReferenceQueue;
    +import java.util.IdentityHashMap;
    +import java.util.LinkedList;
    +import java.util.List;
    +import java.util.Map;
    + * This implementation of an {@link AbstractCloseableRegistry} registers {@link WrappingProxyCloseable}.
    + * the proxy becomes subject to GC, this registry takes care of closing unclosed {@link
    + * <p>
    + * Phantom references are used to track when {@link org.apache.flink.util.WrappingProxy}s
of {@link Closeable} got
    + * GC'ed. We ensure that the wrapped {@link Closeable} is proeprly closed to avoid resource
    --- End diff --
    typo: properly

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message