flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request #2691: [FLINK-4910] Introduce safety net for closing file...
Date Thu, 27 Oct 2016 13:29:27 GMT
Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2691#discussion_r85330867
  
    --- Diff: flink-core/src/main/java/org/apache/flink/core/fs/SafetyNetWrapperFileSystem.java
---
    @@ -0,0 +1,167 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.core.fs;
    +
    +import org.apache.flink.configuration.Configuration;
    +import org.apache.flink.util.Preconditions;
    +import org.apache.flink.util.WrappingProxy;
    +
    +import java.io.IOException;
    +import java.net.URI;
    +
    +/**
    + * This is a {@link WrappingProxy} around {@link FileSystem} which (i) wraps all opened
streams as
    + * {@link ClosingFSDataInputStream} or {@link ClosingFSDataOutputStream} and (ii) registers
them to
    + * a {@link SafetyNetCloseableRegistry}.
    + *
    + * Streams obtained by this are therefore managed by the {@link SafetyNetCloseableRegistry}
to prevent resource leaks
    + * from unclosed streams.
    + */
    +public class SafetyNetWrapperFileSystem extends FileSystem implements WrappingProxy<FileSystem>
{
    +
    +	private final SafetyNetCloseableRegistry registry;
    +	private final FileSystem unsafeFileSystem;
    +
    +	public SafetyNetWrapperFileSystem(FileSystem unsafeFileSystem, SafetyNetCloseableRegistry
registry) {
    +		this.registry = Preconditions.checkNotNull(registry);
    +		this.unsafeFileSystem = Preconditions.checkNotNull(unsafeFileSystem);
    +	}
    +
    +	public static FileSystem getLocalFileSystem() {
    --- End diff --
    
    Overriding the static methods is probably not necessary. I would not expect to use `SafetyNetWrapperFileSystem.get(...)`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message