flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #2686: [FLINK-4743] The sqrt/power function not accept th...
Date Wed, 26 Oct 2016 20:58:34 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2686#discussion_r85217190
  
    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/sql/AggregationsITCase.scala
---
    @@ -258,4 +258,22 @@ class AggregationsITCase(
         // must fail. grouping sets are not supported
         tEnv.sql(sqlQuery).toDataSet[Row]
       }
    +
    +  @Test
    +  def testSqrtOfAggregatedSet(): Unit = {
    --- End diff --
    
    I think we do not need this ITCase. 
    The `PowerExpressionTest` should cover all cases.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message