flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vijikarthi <...@git.apache.org>
Subject [GitHub] flink pull request #2425: FLINK-3930 Added shared secret based authorization...
Date Wed, 26 Oct 2016 16:41:43 GMT
Github user vijikarthi commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2425#discussion_r85167083
  
    --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java
---
    @@ -108,6 +111,11 @@
     
     	private final Options ALL_OPTIONS;
     
    +	private static final String fileName = "yarn-app.ini";
    +	private static final String cookieKey = "secureCookie";
    --- End diff --
    
    Yes, I will make the change. 
    - Do you object to retain the ini file format and port the current properties file implementation
to INI format (to persist multiple application states)?
    
    - Per current implementation (retrieveCluster), the CLI code fetches the application ID
from properties file if not supplied through CLI argument. When we support multiple application
state, then we expect application ID to be supplied always since there could be more than
one application ID and the default functionality will go away. Do you concur? 
    
    >
    If we really need to provide backward compatibility support, then we could return the
application ID from the INI file should there be just only instance persisted? If more than
one application ID exists, then we throw an error indicating "Application ID" needs to be
supplied as CLI argument.
    
    Please let me know how you want me to approach and I will make the changes accordingly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message